Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PROJECT_NAME env var to custom run step #578

Merged
merged 3 commits into from
Apr 8, 2019
Merged

Add PROJECT_NAME env var to custom run step #578

merged 3 commits into from
Apr 8, 2019

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Apr 8, 2019

lkysow
lkysow commented Apr 8, 2019
View reviewed changes
server/events/runtime/run_step_runner_test.go
ExpOut string
ExpErr string
Command string
ProjectName string
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikovirtala what I intended was you add the ProjectName here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. You give the ProjectName a value inside the cases struct. - That's what I was wondering how to do it. As easy as its part. :)

@lkysow lkysow mentioned this pull request Apr 8, 2019
Merged
@codecov
Copy link

codecov bot commented Apr 8, 2019 •
edited
Loading

Codecov Report

Merging #578 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
+ Coverage   72.13%   72.13%   +<.01%     
==========================================
  Files          61       61              
  Lines        4618     4619       +1     
==========================================
+ Hits         3331     3332       +1     
  Misses       1043     1043              
  Partials      244      244
Impacted Files Coverage Δ
server/events/pending_plan_finder.go 78.04% <ø> (ø) ⬆️
server/events/runtime/runtime.go 78.94% <ø> (ø) ⬆️
server/events/runtime/run_step_runner.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f54257...cf490f8. Read the comment docs.

@lkysow lkysow merged commit 9115e8f into master Apr 8, 2019
@lkysow lkysow deleted the runstep branch April 8, 2019 14:22
@lkysow
Copy link
Member Author

lkysow commented Apr 10, 2019

@nikovirtala can you also update https://www.runatlantis.io/docs/custom-workflows.html#custom-run-command

@nikovirtala
Copy link
Contributor

@lkysow I can update it. Do you want just an addition to the list of variables or with a more complete use case? If latter, I could also include the one how we are using the $WORKSPACE variable to set up workspace specific .tfvars.

@lkysow
Copy link
Member Author

lkysow commented Apr 15, 2019

I think just adding it to the list of variables.

@philchristensen philchristensen mentioned this pull request Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikovirtala nikovirtala nikovirtala left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PROPOSAL] Expose project name as environmental variable in run steps
2 participants
@lkysow @nikovirtala